Renderer flag #37529
Closed
Renderer flag #37529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgp1130
force-pushed
the
renderer-flag
branch
4 times, most recently
from
e45c89f
to
bc13db9
Compare
This checks for a Bazel flag in `ng_module()` in the `_renderer` attribute which specifies the renderer to use for the build. The main advantage of this flag is that it can be overridden with [Bazel transitions](https://docs.bazel.build/versions/master/skylark/config.html), giving much more flexibility for migrating individual applications in a Bazel workspace to Ivy. This flag is not intended to replace `--config ivy` or `--define angular_ivy_enabled=True` (although it technically could). As a result, this flag is not and will not actually be used anywhere in the `angular/angular` repo. Instead, a `string_flag()` is provided internally which sets the renderer via a transition. See http://cl/315749946. Note that this does **not** introduce a dependency on Skylib for `angular/angular`. The dependency isn't actually necessary because `BuildSettingInfo` is not used externally anyways. By doing this, it is not necessary for downstream, external workspaces to depend on Skylib.
dgp1130
added
area: bazel
|
/cc @IgorMinar. |
dgp1130
removed
the
action: review
|
Forced google3 passing as only failures appear to be flakes (View Engine, Ivy). |
kyliau
approved these changes
Jun 12, 2020
ngwattcos
pushed a commit
to ngwattcos/angular
that referenced
this pull request
Jun 25, 2020
This checks for a Bazel flag in `ng_module()` in the `_renderer` attribute which specifies the renderer to use for the build. The main advantage of this flag is that it can be overridden with [Bazel transitions](https://docs.bazel.build/versions/master/skylark/config.html), giving much more flexibility for migrating individual applications in a Bazel workspace to Ivy. This flag is not intended to replace `--config ivy` or `--define angular_ivy_enabled=True` (although it technically could). As a result, this flag is not and will not actually be used anywhere in the `angular/angular` repo. Instead, a `string_flag()` is provided internally which sets the renderer via a transition. See http://cl/315749946. Note that this does **not** introduce a dependency on Skylib for `angular/angular`. The dependency isn't actually necessary because `BuildSettingInfo` is not used externally anyways. By doing this, it is not necessary for downstream, external workspaces to depend on Skylib. PR Close angular#37529
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
profanis
pushed a commit
to profanis/angular
that referenced
this pull request
Sep 5, 2020
This checks for a Bazel flag in `ng_module()` in the `_renderer` attribute which specifies the renderer to use for the build. The main advantage of this flag is that it can be overridden with [Bazel transitions](https://docs.bazel.build/versions/master/skylark/config.html), giving much more flexibility for migrating individual applications in a Bazel workspace to Ivy. This flag is not intended to replace `--config ivy` or `--define angular_ivy_enabled=True` (although it technically could). As a result, this flag is not and will not actually be used anywhere in the `angular/angular` repo. Instead, a `string_flag()` is provided internally which sets the renderer via a transition. See http://cl/315749946. Note that this does **not** introduce a dependency on Skylib for `angular/angular`. The dependency isn't actually necessary because `BuildSettingInfo` is not used externally anyways. By doing this, it is not necessary for downstream, external workspaces to depend on Skylib. PR Close angular#37529
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: http://b/158246077
Currently there is no way to set a particular
ng_module()to build with View Engine or Ivy via a Bazel transition. Choosing a renderer is an "all or nothing" approach, where the entire compilation uses one renderer or the other.What is the new behavior?
ng_module()now supports astring_flag()being provided as a_rendererattribute and will use it to decide whether to build with View Engine or Ivy. Such flags can be set via a transition on a per-target basis, making the flag much more flexible for migration use cases.Does this PR introduce a breaking change?
Other information
This flag is not intended for external use cases and will only ever be set inside google3. It is also not intended to replace
--config ivyor--define angular_ivy_enabled=True.See cl/315749946 for a g3 patch which adds the flag to be compatible with this PR.